Mercurial > hg > blitz_condensed
changeset 3:d3ec5ebc3dba
Fix up a small race-condition and and a todo for thread-safety in MatchSetImpl.
| author | Dan Creswell <dan.creswell@gmail.com> |
|---|---|
| date | Sat, 25 Apr 2009 08:38:27 +0100 |
| parents | 47767be3a265 |
| children | 7b6200980805 |
| files | src/org/dancres/blitz/remote/MatchSetImpl.java src/org/dancres/blitz/remote/view/EntryViewFactory.java |
| diffstat | 2 files changed, 9 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/org/dancres/blitz/remote/MatchSetImpl.java Thu Mar 26 18:01:14 2009 +0000 +++ b/src/org/dancres/blitz/remote/MatchSetImpl.java Sat Apr 25 08:38:27 2009 +0100 @@ -15,6 +15,12 @@ import org.dancres.blitz.remote.view.EntryViewUID; +/** + * @todo Consider making this thread safe, even though multi-threading against a MatchSet makes little sense in most cases + * (like multi-thread JS transactions). + * + * @author dan + */ public class MatchSetImpl implements MatchSet { static final int CHUNK_SIZE = 50;
--- a/src/org/dancres/blitz/remote/view/EntryViewFactory.java Thu Mar 26 18:01:14 2009 +0000 +++ b/src/org/dancres/blitz/remote/view/EntryViewFactory.java Sat Apr 25 08:38:27 2009 +0100 @@ -122,6 +122,9 @@ } } + /** + @todo Fix up the missing synchronization inside the loop (should be around the get and expire test) + */ public void reap(ReapFilter aFilter) { /* No reap filters will be configured so we can ignore those - see