# HG changeset patch # User Dan Creswell # Date 1240645107 -3600 # Node ID d3ec5ebc3dbae883f6432254c41fa2b88f9e0ab5 # Parent 47767be3a265bd65dbfe561cddc3267c8f592a7f Fix up a small race-condition and and a todo for thread-safety in MatchSetImpl. diff -r 47767be3a265 -r d3ec5ebc3dba src/org/dancres/blitz/remote/MatchSetImpl.java --- a/src/org/dancres/blitz/remote/MatchSetImpl.java Thu Mar 26 18:01:14 2009 +0000 +++ b/src/org/dancres/blitz/remote/MatchSetImpl.java Sat Apr 25 08:38:27 2009 +0100 @@ -15,6 +15,12 @@ import org.dancres.blitz.remote.view.EntryViewUID; +/** + * @todo Consider making this thread safe, even though multi-threading against a MatchSet makes little sense in most cases + * (like multi-thread JS transactions). + * + * @author dan + */ public class MatchSetImpl implements MatchSet { static final int CHUNK_SIZE = 50; diff -r 47767be3a265 -r d3ec5ebc3dba src/org/dancres/blitz/remote/view/EntryViewFactory.java --- a/src/org/dancres/blitz/remote/view/EntryViewFactory.java Thu Mar 26 18:01:14 2009 +0000 +++ b/src/org/dancres/blitz/remote/view/EntryViewFactory.java Sat Apr 25 08:38:27 2009 +0100 @@ -122,6 +122,9 @@ } } + /** + @todo Fix up the missing synchronization inside the loop (should be around the get and expire test) + */ public void reap(ReapFilter aFilter) { /* No reap filters will be configured so we can ignore those - see